show user friendly error if git is not found #15574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-pavel-git.1 because the annotations in the pull request description changed |
roboquat
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
|
started the job as gitpod-build-pavel-git.3 because the annotations in the pull request description changed |
|
@gitpod-io/engineering-ide hey there, could we trouble you for a review on this PR? It'll help users be more successful earlier with their custom image builds, when they forget to include |
|
Thank you, @filiptronicek ! 🙏 |
roboquat
added
deployed: IDE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Show user friendly error and reason for failure if user uses base image that does not include
git.Otherwise workspace will be stuck in
content initializationphase forever, which is a bad user experience.(We do require base image to have git and gitpod user, but end user may forget about those requirements).
This is how the error will be presented to the user:
Related Issue(s)
Fixes #
How to test
Open a repo that uses this gitpod dockerfile:
Notice it will fail with user friendly error explaining why.
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh